Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential typo in early stopping monitor keys #3213

Merged
merged 4 commits into from
Aug 27, 2020
Merged

Fix potential typo in early stopping monitor keys #3213

merged 4 commits into from
Aug 27, 2020

Conversation

minhduc0711
Copy link
Contributor

@minhduc0711 minhduc0711 commented Aug 27, 2020 •
edited by Borda
Loading

What does this PR do?

Fixes typo in monitor key.

Fixes #3214

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team August 27, 2020 01:43
@ToucheSir ToucheSir mentioned this pull request Aug 27, 2020
Closed
7 tasks
williamFalcon and others added 3 commits August 26, 2020 22:20
@williamFalcon
ref: group prepare data hook (6) (Lightning-AI#3212)
464a0e7 
* group prepare data hook

* group prepare data hook

* group prepare data hook

* group prepare data hook

* group prepare data hook

* group prepare data hook

* group prepare data hook
@minhduc0711 @williamFalcon
Fix typo
762006b
@williamFalcon
Merge branch 'minhduc0711-patch-1' of https://github.com/minhduc0711/…
ba5cfdd 
…pytorch-lightning into minhduc0711-patch-1
@williamFalcon williamFalcon merged commit 4d98419 into Lightning-AI:master Aug 27, 2020
@minhduc0711 minhduc0711 deleted the minhduc0711-patch-1 branch August 27, 2020 04:56
@Borda Borda added the bug Something isn't working label Aug 27, 2020
@Borda Borda added this to the 0.9.x milestone Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
pl:0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@minhduc0711 @williamFalcon @Borda