Fix global step increment on training_epoch_end #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Looks like all tests are passing. Maybe add a test too to make sure its all good in future 🙂 |
|
That's the plan :) |
|
William will solve this in his branch |
|
The horovod test is failing randomly.... also verified on my local.
@tgaddair mind taking a look in a follow on PR? |
|
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-27 23:50:23 UTC |
|
|
||
| # Called every 3 steps, meaning for 1 epoch of 11 batches, it is called 3 times with gamma=0.1 | ||
| assert pytest.approx(init_lr * 0.1) == adjusted_lr2 | ||
| # @pytest.mark.skipif(platform.system() == "Windows", reason="Horovod is not supported on Windows") |
There was a problem hiding this comment.
@tgaddair weird error... happens only on some machines some times haha
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
global_step gets incremented if training_epoch_end is implemented.
This shouldn't be necessary and will lead to a misalignment in logs.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃