Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conda: PT 1.8 #3833

Merged
merged 19 commits into from
Nov 12, 2020
Merged

Conda: PT 1.8 #3833

merged 19 commits into from
Nov 12, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 3, 2020 •
edited
Loading

What does this PR do?

PT 1.7 was removed from pytorch-nightly channel but still missing on standard pytorch...
Resolves #4596
resolves #4587

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added ci Continuous Integration 3rd party Related to a 3rd-party labels Oct 3, 2020
This was referenced Oct 3, 2020
Merged
Merged
@codecov
Copy link

codecov bot commented Oct 6, 2020 •
edited
Loading

Codecov Report

Merging #3833 (2139c7d) into master (35f00df) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3833   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         116     116           
  Lines        8879    8879           
======================================
- Hits         8264    8261    -3     
- Misses        615     618    +3

@Borda Borda added this to the 1.0.x milestone Oct 20, 2020
@stale
Copy link

stale bot commented Nov 3, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Nov 3, 2020
@ydcjeff ydcjeff removed the won't fix This will not be worked on label Nov 3, 2020
@Borda
Copy link
Member Author

Borda commented Nov 3, 2020

good point here actions/runner#2347

@ydcjeff
Copy link
Contributor

ydcjeff commented Nov 10, 2020

@Borda how about this kind of nightly testing?

@Borda
Copy link
Member Author

Borda commented Nov 10, 2020

@ydcjeff I would probably just add testing in Conda env as it will be just one extra test and not 3 (per OS) * 2 (py) = 6
also, it would be consistent with other PT versions we are testing...

@ydcjeff
Copy link
Contributor

ydcjeff commented Nov 10, 2020 •
edited
Loading

Ok @Borda sorry for the inconvenience.

Also you may want to unfreeze torchvision too.

@edenlightning edenlightning modified the milestones: 1.0.x, 1.0.7 Nov 10, 2020
@Borda Borda modified the milestones: 1.0.7, 1.0.x Nov 11, 2020
@Borda
Copy link
Member Author

Borda commented Nov 12, 2020

Ok @Borda sorry for the inconvenience.
Also you may want to unfreeze torchvision too.

all good, if you want I left a few todos, basically to check how could we install PT with pip, I could not find a solution... (the only one which I do not like is to download the wheel locally and try install but not sure about OS/Py/versions compatibility)

@Borda Borda added the priority: 1 Medium priority task label Nov 12, 2020
@Borda Borda added the ready PRs ready to be merged label Nov 12, 2020
tchaton
tchaton approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work there !

@Borda Borda merged commit bd6c413 into master Nov 12, 2020
@Borda Borda deleted the ci/pt-1.8 branch November 12, 2020 14:03
Borda added a commit that referenced this pull request Nov 12, 2020
@Borda
Conda: PT 1.8 (#3833)
1202823 
* PT 1.8

* unfreeze PT

* drop nightly from full

* add PT 1.8 to workflow

* readme table

* cuda

* skip cuda

* test 1.8

* unfreeze torch vision

Co-authored-by: ydcjeff <ydcjeff@outlook.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>

(cherry picked from commit bd6c413)
Borda added a commit that referenced this pull request Nov 12, 2020
@Borda
Conda: PT 1.8 (#3833)
0df4a22 
* PT 1.8

* unfreeze PT

* drop nightly from full

* add PT 1.8 to workflow

* readme table

* cuda

* skip cuda

* test 1.8

* unfreeze torch vision

Co-authored-by: ydcjeff <ydcjeff@outlook.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>

(cherry picked from commit bd6c413)
Borda added a commit that referenced this pull request Nov 12, 2020
@Borda
Conda: PT 1.8 (#3833)
050aec8 
* PT 1.8

* unfreeze PT

* drop nightly from full

* add PT 1.8 to workflow

* readme table

* cuda

* skip cuda

* test 1.8

* unfreeze torch vision

Co-authored-by: ydcjeff <ydcjeff@outlook.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>

(cherry picked from commit bd6c413)
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
@Borda @tchaton
@SkafteNicki @rohitgr7
Conda: PT 1.8 (#3833)
58183c2 
* PT 1.8

* unfreeze PT

* drop nightly from full

* add PT 1.8 to workflow

* readme table

* cuda

* skip cuda

* test 1.8

* unfreeze torch vision

Co-authored-by: ydcjeff <ydcjeff@outlook.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydcjeff ydcjeff ydcjeff approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@tchaton tchaton tchaton approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@nateraw nateraw Awaiting requested review from nateraw

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@teddykoker teddykoker Awaiting requested review from teddykoker

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

Assignees
No one assigned
Labels
3rd party Related to a 3rd-party ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.0.x
Development

Successfully merging this pull request may close these issues.

upgrading PL via pip uninstalls pytorch-1.8 Segmentation fault on import with RTX 3090
5 participants
@Borda @ydcjeff @tchaton @SkafteNicki @edenlightning