ref: adding compute environments (1/n) #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-04 04:38:16 UTC |
Codecov Report
@@ Coverage Diff @@
## master #3837 +/- ##
======================================
- Coverage 88% 88% -0%
======================================
Files 111 115 +4
Lines 8812 8882 +70
======================================
+ Hits 7769 7795 +26
- Misses 1043 1087 +44 |
Borda
reviewed
Oct 4, 2020
| def __init__(self, world_size): | ||
| super().__init__(world_size) | ||
|
|
||
| def master_address(self): |
| port = os.environ.get('MASTER_PORT') | ||
| return port | ||
|
|
||
| def world_size(self): |
There was a problem hiding this comment.
this probably also does not change during training, so a property?
| @@ -0,0 +1,13 @@ | |||
| class ClusterEnvironment: | |||
There was a problem hiding this comment.
to the file general - missing Licence
| @@ -0,0 +1,3 @@ | |||
| from pytorch_lightning.cluster_environments.cluster_environment import ClusterEnvironment | |||
There was a problem hiding this comment.
can we rename this package just to environments as TE is not a true cluster and there may be another non cluster evns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: adding compute environments (1/n)