Mocking loggers (part 3a, comet) #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3851 +/- ##
=======================================
+ Coverage 83% 87% +4%
=======================================
Files 117 117
Lines 9105 9106 +1
=======================================
+ Hits 7573 7966 +393
+ Misses 1532 1140 -392 |
|
This pull request is now in conflict... :( |
awaelchli
force-pushed
the
tests/mock-comet-1
branch
from
72c2b90
to
29a2aa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes after #3617
Part 1 of comet mocking, step by step
a small refactor in order to keep PRs small and easy to review.