Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated callbacks #3979

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 8, 2020

What does this PR do?

removing deprecated callbacks GpuUsageLogger and LearningRateLogger

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactor label Oct 8, 2020
@Borda Borda added this to the 1.0 milestone Oct 8, 2020
@mergify mergify bot requested a review from a team October 8, 2020 08:05
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #3979 into master will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3979   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files         216     212    -4     
  Lines       15569   15606   +37     
======================================
+ Hits        13870   13909   +39     
+ Misses       1699    1697    -2     

@williamFalcon williamFalcon merged commit 36f0c8a into master Oct 8, 2020
@Borda Borda deleted the refactor/rm-depr-callbacks branch October 9, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants