add on_train_batch_start/end, chpt hooks in hooks docs [ci skip] #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4023 +/- ##
======================================
Coverage 87% 87%
======================================
Files 214 214
Lines 15602 15602
======================================
Hits 13637 13637
Misses 1965 1965 |
Borda
approved these changes
Oct 9, 2020
SkafteNicki
approved these changes
Oct 9, 2020
Borda
requested review from
edenlightning,
awaelchli,
justusschock,
rohitgr7,
SeanNaren,
williamFalcon and
yukw777
SeanNaren
approved these changes
Oct 9, 2020
rohitgr7
reviewed
Oct 9, 2020
| - :meth:`~pytorch_lightning.core.lightning.LightningModule.tbptt_split_batch` | ||
| - :meth:`~pytorch_lightning.core.lightning.LightningModule.training_step` | ||
| - :meth:`~pytorch_lightning.core.lightning.LightningModule.training_step_end` (optional) | ||
| - :meth:`~pytorch_lightning.core.hooks.ModelHooks.on_before_zero_grad` | ||
| - :meth:`~pytorch_lightning.core.hooks.ModelHooks.backward` | ||
| - :meth:`~pytorch_lightning.core.hooks.ModelHooks.on_after_backward` | ||
| - ``optimizer.step()`` | ||
| - :meth:`~pytorch_lightning.core.hooks.ModelHooks.on_train_batch_end` | ||
| - :meth:`~pytorch_lightning.core.lightning.LightningModule.training_epoch_end` | ||
| - :meth:`~pytorch_lightning.core.hooks.ModelHooks.on_epoch_end` |
There was a problem hiding this comment.
Why keep on_epoch_end if we have on_train_epoch_end? They are basically doing the same thing right? Same with on_epoch_start.
There was a problem hiding this comment.
true. mind removing those?
There was a problem hiding this comment.
I see no deprecation has been set in the docstrings yet for these ModelHooks, should I still remove them? Also, similar hooks are present in Callback as well on_batch_start, on_batch_end, on_epoch_start, on_epoch_end. Should we remove them all since all of them have their alternatives with prefix on_train_*??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up of #3980
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃