Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: enable custom clusters (1/n) #4048

Merged
merged 7 commits into from
Oct 10, 2020
Merged

ref: enable custom clusters (1/n) #4048

merged 7 commits into from
Oct 10, 2020

Conversation

williamFalcon
Copy link
Contributor

Final refactor was to enable plugins.

The first enabled plugin is a custom cluster env (to support non SLURM clusters).

Next PRs

  1. move the init dataparallel code to a backend
  2. enable passing in backends
  3. enable passing in custom apex amp.

This wraps up the last of the refactors

@mergify mergify bot requested a review from a team October 10, 2020 11:10
@pep8speaks
Copy link

pep8speaks commented Oct 10, 2020

Hello @williamFalcon! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-10 11:25:57 UTC

@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #4048 into master will increase coverage by 1%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4048   +/-   ##
======================================
+ Coverage      92%     92%   +1%     
======================================
  Files         109     105    -4     
  Lines        7871    7794   -77     
======================================
- Hits         7204    7177   -27     
+ Misses        667     617   -50     

@williamFalcon williamFalcon merged commit 2b255a3 into master Oct 10, 2020
@williamFalcon williamFalcon deleted the clus2 branch October 11, 2020 11:35
@Borda Borda added the refactor label Oct 13, 2020
@Borda Borda added this to the 1.0 milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants