fix hparams assign in init #4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
added
bug
tchaton
approved these changes
Oct 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #4189 +/- ##
=======================================
+ Coverage 90% 93% +3%
=======================================
Files 103 103
Lines 7842 7844 +2
=======================================
+ Hits 7053 7277 +224
+ Misses 789 567 -222 |
SkafteNicki
approved these changes
Oct 16, 2020
SeanNaren
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adding saving
hparamseven without usingsave_hyperparametersjust with hard assign in class init (any fist init...)Fixes #4179
Fixes #4186
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃