Optimizer closure #4190
Merged
Optimizer closure #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #4083 too right? |
|
@rohitgr7 Not yet tested, net to get it working first :D |
|
nice. when it's ready, can you add tests that use the mock + count to verify that we perform the expected number of backward passes? also with a non-lbfgs optimizer to make sure we don't break current functionality |
|
@williamFalcon I think @awaelchli is currently looking into this. But no matter who does this: There will definitely be tests! |
|
Hello @justusschock! Thanks for updating this PR.
Comment last updated at 2020-10-21 14:34:14 UTC |
justusschock
requested review from
ananyahjha93,
awaelchli,
Borda,
lezwon,
rohitgr7,
SeanNaren and
tchaton
awaelchli
reviewed
Oct 21, 2020
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
awaelchli
reviewed
Oct 21, 2020
awaelchli
reviewed
Oct 21, 2020
SeanNaren
approved these changes
Oct 21, 2020
|
The GPU tests did not run, because of horovod installation failing, so we did not see the problem with amp closure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4188 and also fixes #2785
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃