Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use checkpoint_connector.hpc_save in SLURMConnector #4217

Merged
merged 1 commit into from
Oct 18, 2020

Conversation

EspenHa
Copy link
Contributor

@EspenHa EspenHa commented Oct 18, 2020

What does this PR do?

Fixes #4208. Simply change SLURMConnector to use trainer.checkpoint_connector.hpc_save instead of trainer.hpc_save.

Note that I have not tested this as I don't have access to a SLURM cluster at the moment.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team October 18, 2020 13:28
@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #4217 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4217   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         103     103           
  Lines        7848    7848           
======================================
  Hits         7281    7281           
  Misses        567     567           

@williamFalcon williamFalcon merged commit 66e58f5 into Lightning-AI:master Oct 18, 2020
@EspenHa EspenHa deleted the fix-slurm-hpc_save branch October 18, 2020 16:10
@Borda Borda added the bug Something isn't working label Oct 18, 2020
@andreamad8
Copy link

I just tested, it works 👍🏻

@Borda Borda added this to the 1.0.x milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'Trainer' object has no attribute 'hpc_save'
4 participants