[docs] Fix ModelCheckpoint examples #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydcjeff
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
Examples are showing correctly |
Codecov Report
@@ Coverage Diff @@
## master #4426 +/- ##
======================================
Coverage 93% 93%
======================================
Files 111 111
Lines 8138 8138
======================================
Hits 7563 7563
Misses 575 575 |
|
oh okay. Thanks @ydcjeff. I should always have a look at docs before merging any changes. |
rohitgr7
approved these changes
Oct 29, 2020
awaelchli
approved these changes
Oct 29, 2020
justusschock
approved these changes
Oct 30, 2020
|
@ydcjeff any idea about failing tests? |
@justusschock because those are tested with 1.7, a PR is on the way #3821 |
Borda
pushed a commit
that referenced
this pull request
Nov 4, 2020
(cherry picked from commit 20a8eaa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix ModelCheckpoint Examples
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃