Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] distributed_backend -> accelerator #4429

Merged
merged 5 commits into from
Oct 29, 2020
Merged

[docs] distributed_backend -> accelerator #4429

merged 5 commits into from
Oct 29, 2020

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Oct 29, 2020

What does this PR do?

Fixes #4394

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7
Copy link
Contributor

there are few more places in the docs and tests where it's still distributed_backend. Should those be changed too??

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #4429 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4429   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         111     111           
  Lines        8070    8070           
======================================
  Hits         7490    7490           
  Misses        580     580           

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Oct 29, 2020

there are few more places in the docs and tests where it's still distributed_backend. Should those be changed too??

not sure about tests, docs can be changed.

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Oct 29, 2020

Don't merge it yet. have some docs building issue.
Thank you @rohitgr7

@ydcjeff ydcjeff merged commit ebe3a31 into master Oct 29, 2020
@ydcjeff ydcjeff deleted the acc branch October 29, 2020 18:15
Borda pushed a commit that referenced this pull request Nov 4, 2020
* distributed_backend -> accelerator

* distributed_backend -> accelerator

* use_amp -> precision

* format

Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
(cherry picked from commit ebe3a31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] replace distributed_backend with accelerator in docs
5 participants