Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Lock cuda version #4453

Merged
merged 5 commits into from
Oct 31, 2020
Merged

[docker] Lock cuda version #4453

merged 5 commits into from
Oct 31, 2020

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Oct 31, 2020

What does this PR do?

PyTorch 1.7 ships binaries with CUDA 11 by default, so apex is failed to install from source
Lock cuda=CUDA_VERSION in building dockers

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ydcjeff ydcjeff marked this pull request as draft October 31, 2020 05:08
@ydcjeff ydcjeff added the ci Continuous Integration label Oct 31, 2020
@ydcjeff ydcjeff added this to the 1.0.x milestone Oct 31, 2020
@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #4453 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4453   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         113     113           
  Lines        8191    8191           
======================================
  Hits         7623    7623           
  Misses        568     568           

@ydcjeff ydcjeff marked this pull request as ready for review October 31, 2020 09:22
@ydcjeff ydcjeff merged commit 1d594c5 into master Oct 31, 2020
@ydcjeff ydcjeff deleted the ci/docker branch October 31, 2020 13:47
Borda pushed a commit that referenced this pull request Nov 4, 2020
* lock cuda version

* back to normal

(cherry picked from commit 1d594c5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants