-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Note on running metric in dp #4494
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4494 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 116 116
Lines 8833 8833
======================================
- Hits 8235 8232 -3
- Misses 598 601 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch ! Any idea on how to solve ?
@tchaton Only solution is to make a custom version of |
* note * Update docs/source/metrics.rst Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> Co-authored-by: Jeff Yang <ydcjeff@outlook.com> (cherry picked from commit 01a925d)
* note * Update docs/source/metrics.rst Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> Co-authored-by: Jeff Yang <ydcjeff@outlook.com> (cherry picked from commit 01a925d)
* note * Update docs/source/metrics.rst Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> Co-authored-by: Jeff Yang <ydcjeff@outlook.com> (cherry picked from commit 01a925d)
* note * Update docs/source/metrics.rst Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
What does this PR do?
Fixes #4353
Metrics needs to be treated differently in DP mode (until we have statefull DP #1895). This PR adds a note to the docs what the user can do for now.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃