Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add congratulations at the end of our notebooks #4555

Merged
merged 2 commits into from
Nov 7, 2020

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 6, 2020

What does this PR do?

This PR add a message at the end of each notebook

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added the feature Is an improvement or enhancement label Nov 6, 2020
@tchaton tchaton added this to the 1.0.x milestone Nov 6, 2020
@tchaton tchaton self-assigned this Nov 6, 2020
@tchaton
Copy link
Contributor Author

tchaton commented Nov 6, 2020

Added this markdown at the end of each notebooks !

Screenshot 2020-11-06 at 18 07 56

@Borda Borda added docs Documentation related example labels Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #4555 (c00fe4f) into master (6e5f232) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4555   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         116     116           
  Lines        8815    8815           
======================================
- Hits         8228    8225    -3     
- Misses        587     590    +3     

@edenlightning
Copy link
Contributor

Until we get https://www.reviewnb.com/ ill just put suggestions here:

  1. Some of the exclamation marks can be replaced with colons, "You can do so in the following ways:"
  2. Capitalization
  3. Add link to slack
  4. "Interested in SOTA models? Check out Bolts. Bolts has a collection of models, all implemented in lightning, ...."
  5. "Contribute"
  • "You can also contribute your own notebooks with useful examples"

@Borda
Copy link
Member

Borda commented Nov 6, 2020

@williamFalcon could you pls add it, @teddykoker @edenafek what are the bullet points do so?

@tchaton
Copy link
Contributor Author

tchaton commented Nov 7, 2020

Screenshot 2020-11-07 at 11 48 55

@tchaton tchaton merged commit 854c136 into master Nov 7, 2020
@tchaton tchaton deleted the feat/update_notebooks branch November 7, 2020 12:05
SeanNaren pushed a commit that referenced this pull request Nov 10, 2020
* add congratulations at the end of our notebooks

* udpate image

(cherry picked from commit 854c136)
SeanNaren pushed a commit that referenced this pull request Nov 11, 2020
* add congratulations at the end of our notebooks

* udpate image

(cherry picked from commit 854c136)
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
* add congratulations at the end of our notebooks

* udpate image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related example feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants