-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefix argument in loggers #4557
Conversation
Hello @rohitgr7! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-11-21 23:21:00 UTC |
Codecov Report
@@ Coverage Diff @@
## master #4557 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 117 117
Lines 8977 9002 +25
======================================
+ Hits 8353 8375 +22
- Misses 624 627 +3 |
not sure why some tests are getting cancelled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@awaelchli do you know why some tests here are getting canceled here?? Something wrong with mock tests here? |
@tchaton make sure tests here are good? |
44ec8e4
to
363cf55
Compare
@awaelchli can't get the tests working. Not familiar with the error it's raising. Can you check, please?? Thanks. |
ok, I try to find what's wrong :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohitgr7 see my modifications to test.
- need to mock each 3rd party experiment object, because we don't install it in CI
- each logger has slightly different interface
with the mocks it allows us to catch the exact call to the experiment object.
What does this PR do?
Fixes #4537
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃