Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix argument in loggers #4557

Merged
merged 11 commits into from
Nov 22, 2020
Merged

Add prefix argument in loggers #4557

merged 11 commits into from
Nov 22, 2020

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Nov 6, 2020

What does this PR do?

Fixes #4537

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Nov 6, 2020

Hello @rohitgr7! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-21 23:21:00 UTC

@rohitgr7 rohitgr7 changed the title Add prefix parameter in loggers Add prefix argument in loggers Nov 6, 2020
@rohitgr7 rohitgr7 added feature Is an improvement or enhancement logger Related to the Loggers labels Nov 6, 2020
@rohitgr7 rohitgr7 modified the milestones: 1.1, 1.0.x Nov 6, 2020
@rohitgr7 rohitgr7 marked this pull request as ready for review November 6, 2020 21:13
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #4557 (e38bddb) into master (db69d16) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4557   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         117     117           
  Lines        8977    9002   +25     
======================================
+ Hits         8353    8375   +22     
- Misses        624     627    +3     

@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Nov 8, 2020

not sure why some tests are getting cancelled

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition !

Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohitgr7
Copy link
Contributor Author

@awaelchli do you know why some tests here are getting canceled here?? Something wrong with mock tests here?

@edenlightning edenlightning modified the milestones: 1.0.x, 1.0.7 Nov 10, 2020
@Borda Borda modified the milestones: 1.0.7, 1.0.x Nov 11, 2020
@edenlightning edenlightning modified the milestones: 1.0.x, 1.0.7 Nov 13, 2020
@Borda Borda modified the milestones: 1.0.7, 1.0.x Nov 13, 2020
@Borda Borda added the ready PRs ready to be merged label Nov 13, 2020
@edenlightning edenlightning modified the milestones: 1.0.x, 1.1 Nov 16, 2020
@edenlightning
Copy link
Contributor

@tchaton make sure tests here are good?

pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved
tests/loggers/test_all.py Outdated Show resolved Hide resolved
tests/loggers/test_all.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 removed the ready PRs ready to be merged label Nov 18, 2020
@rohitgr7
Copy link
Contributor Author

@awaelchli can't get the tests working. Not familiar with the error it's raising. Can you check, please?? Thanks.

@awaelchli
Copy link
Contributor

ok, I try to find what's wrong :)

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitgr7 see my modifications to test.

  1. need to mock each 3rd party experiment object, because we don't install it in CI
  2. each logger has slightly different interface
    with the mocks it allows us to catch the exact call to the experiment object.

tests/loggers/test_all.py Outdated Show resolved Hide resolved
@awaelchli awaelchli merged commit 2d9d7e4 into master Nov 22, 2020
@awaelchli awaelchli deleted the feature/logger_prefix branch November 22, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement logger Related to the Loggers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefix argument in loggers
8 participants