Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix docstring of LightningModule._auto_collect_args() #4585

Merged

Conversation

akihironitta
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #4585 (9586c7e) into master (e01190e) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4585   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         116     116           
  Lines        8833    8833           
======================================
  Hits         8235    8235           
  Misses        598     598           

Copy link
Contributor

@ydcjeff ydcjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Akihi

@ydcjeff ydcjeff added ready PRs ready to be merged bug Something isn't working docs Documentation related labels Nov 9, 2020
@ydcjeff ydcjeff added this to the 1.0.x milestone Nov 9, 2020
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many ducks visited these docs!

@ydcjeff ydcjeff merged commit 45a6959 into Lightning-AI:master Nov 9, 2020
SeanNaren pushed a commit that referenced this pull request Nov 10, 2020
Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
(cherry picked from commit 45a6959)
SeanNaren pushed a commit that referenced this pull request Nov 11, 2020
Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
(cherry picked from commit 45a6959)
Borda pushed a commit that referenced this pull request Nov 11, 2020
Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
(cherry picked from commit 45a6959)
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants