-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply import formatting to files in the 2nd top level #4717
Merged
Borda
merged 3 commits into
Lightning-AI:master
from
akihironitta:refactor/import-formatting-second-level
Nov 17, 2020
Merged
Apply import formatting to files in the 2nd top level #4717
Borda
merged 3 commits into
Lightning-AI:master
from
akihironitta:refactor/import-formatting-second-level
Nov 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihironitta
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
November 17, 2020 15:40
ydcjeff
approved these changes
Nov 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #4717 +/- ##
======================================
Coverage 93% 93%
======================================
Files 117 117
Lines 8937 8937
======================================
Hits 8304 8304
Misses 633 633 |
SkafteNicki
approved these changes
Nov 17, 2020
Borda
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akihironitta great work, that is exactly what I had in mind :]
rohitgr7
pushed a commit
that referenced
this pull request
Nov 21, 2020
* Update pyproject.toml * Apply isort to files in second level Co-authored-by: chaton <thomas@grid.ai>
30 tasks
Borda
pushed a commit
that referenced
this pull request
Nov 23, 2020
* Update pyproject.toml * Apply isort to files in second level Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit ece09f0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a follow-up PR of #4242.
This PR mainly changes the config file for isort rather than the codebase so that future PRs can apply import formatter step by step as discussed in #4242 (comment).
(We have a similar list of files to skip
pyright
checks in .pyrightconfig.json)Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃