Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply import formatting to files in the 2nd top level #4717

Merged

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Nov 17, 2020

What does this PR do?

This is a follow-up PR of #4242.

This PR mainly changes the config file for isort rather than the codebase so that future PRs can apply import formatter step by step as discussed in #4242 (comment).

(We have a similar list of files to skip pyright checks in .pyrightconfig.json)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #4717 (f63920a) into master (9a5d40a) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4717   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         117     117           
  Lines        8937    8937           
======================================
  Hits         8304    8304           
  Misses        633     633           

@Borda Borda added the feature Is an improvement or enhancement label Nov 17, 2020
@Borda Borda added this to the 1.0.x milestone Nov 17, 2020
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akihironitta great work, that is exactly what I had in mind :]

@Borda Borda merged commit ece09f0 into Lightning-AI:master Nov 17, 2020
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
* Update pyproject.toml

* Apply isort to files in second level

Co-authored-by: chaton <thomas@grid.ai>
@akihironitta akihironitta mentioned this pull request Nov 22, 2020
30 tasks
Borda pushed a commit that referenced this pull request Nov 23, 2020
* Update pyproject.toml

* Apply isort to files in second level

Co-authored-by: chaton <thomas@grid.ai>
(cherry picked from commit ece09f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants