Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast hparams to dict when not using omegaconf #4770

Merged
merged 8 commits into from
Nov 20, 2020
Merged

Cast hparams to dict when not using omegaconf #4770

merged 8 commits into from
Nov 20, 2020

Conversation

s-rog
Copy link
Contributor

@s-rog s-rog commented Nov 19, 2020 •
edited
Loading

What does this PR do?

Fixes #4542

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@s-rog s-rog requested a review from awaelchli November 19, 2020 08:01
@s-rog s-rog added bug Something isn't working logging Related to the `LoggerConnector` and `log()` priority: 1 Medium priority task labels Nov 19, 2020
@s-rog s-rog added this to the 1.0.x milestone Nov 19, 2020
@s-rog s-rog added checkpointing Related to checkpointing and removed logging Related to the `LoggerConnector` and `log()` labels Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020 •
edited
Loading

Codecov Report

Merging #4770 (539bb82) into master (4803f68) will increase coverage by 3%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #4770    +/-   ##
=======================================
+ Coverage      90%     93%    +3%     
=======================================
  Files         117     117            
  Lines        8968    8967     -1     
=======================================
+ Hits         8084    8335   +251     
+ Misses        884     632   -252

@s-rog s-rog marked this pull request as ready for review November 20, 2020 02:55
Borda
Borda approved these changes Nov 20, 2020
View reviewed changes
tests/checkpointing/test_model_checkpoint.py Outdated Show resolved Hide resolved
@tchaton @Borda
Update tests/checkpointing/test_model_checkpoint.py
5851762 
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
tchaton
tchaton approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

SkafteNicki
SkafteNicki approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-rog s-rog merged commit 42e59c6 into Lightning-AI:master Nov 20, 2020
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
@s-rog @tchaton
@Borda @rohitgr7
Cast hparams to dict when not using omegaconf (#4770)
a320c06 
* init fix

* init test

* more specific dict assert

* update changelog

* Update tests/checkpointing/test_model_checkpoint.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Borda pushed a commit that referenced this pull request Nov 23, 2020
@s-rog @Borda
Cast hparams to dict when not using omegaconf (#4770)
6172b02 
* init fix

* init test

* more specific dict assert

* update changelog

* Update tests/checkpointing/test_model_checkpoint.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

(cherry picked from commit 42e59c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@nateraw nateraw Awaiting requested review from nateraw

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@teddykoker teddykoker Awaiting requested review from teddykoker

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
bug Something isn't working checkpointing Related to checkpointing priority: 1 Medium priority task
Projects
None yet
Milestone
pl:1.0.x
Development

Successfully merging this pull request may close these issues.

Replace AttributeDict in with dict in checkpoint
4 participants
@s-rog @Borda @tchaton @SkafteNicki