Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix] Logging - One epoch delay on training epoch metrics. #4913

Merged
merged 9 commits into from
Dec 1, 2020

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 30, 2020

What does this PR do?

This PR update logging logic for training.

Fixes #4863

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added bug Something isn't working Important logger Related to the Loggers labels Nov 30, 2020
@tchaton tchaton added this to the 1.1 milestone Nov 30, 2020
@tchaton tchaton self-assigned this Nov 30, 2020
@pep8speaks
Copy link

pep8speaks commented Nov 30, 2020

Hello @tchaton! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-01 08:16:41 UTC

@Borda Borda added the design Includes a design discussion label Nov 30, 2020
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Borda Borda assigned SeanNaren and unassigned tchaton Nov 30, 2020
@Borda Borda added the ready PRs ready to be merged label Nov 30, 2020
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #4913 (15b7b0e) into master (ef762a0) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4913   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         122     122           
  Lines        9225    9225           
======================================
  Hits         8545    8545           
  Misses        680     680           

@tchaton tchaton merged commit 1d3724a into master Dec 1, 2020
@tchaton tchaton deleted the bugfix/4863_progress_bar_dict_delayed_by_one_epoch branch December 1, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design Includes a design discussion logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trainer.progress_bar_dict values are delayed by one epoch
7 participants