-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wandb): offset logging step when resuming #5050
Merged
Merged
Changes from 14 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f7c7994
feat(wandb): offset logging step when resuming
borisdayma a93cd0a
feat(wandb): output warnings
borisdayma d00e57a
fix(wandb): allow step to be None
borisdayma dc3794a
test(wandb): update tests
borisdayma eb75676
feat(wandb): display warning only once
borisdayma 69bf4bb
style: fix PEP issues
borisdayma 891acf4
Merge branch 'master' into feat_wandb_resume
borisdayma 5978805
tests(wandb): fix tests
borisdayma dbc15f2
tests(wandb): improve test
borisdayma ea4f88e
style: fix whitespace
borisdayma 1c3bc82
feat: improve warning
borisdayma 6c02a2c
feat(wandb): use variable from class instance
borisdayma 63dcd70
tests(wandb): check warnings
borisdayma c9066cd
Merge branch 'master' into feat_wandb_resume
borisdayma 61cb199
feat(wandb): use WarningCache
borisdayma f7d832e
tests(wandb): fix tests
borisdayma b996d2a
Merge branch 'master' into feat_wandb_resume
borisdayma d4d500e
style: fix formatting
borisdayma e157ce3
Merge branch 'feat_wandb_resume' of https://github.com/borisdayma/pyt…
borisdayma 792a94a
Merge branch 'master' into feat_wandb_resume
borisdayma f930f27
Merge branch 'master' into feat_wandb_resume
borisdayma 91e089d
Merge branch 'master' into feat_wandb_resume
borisdayma 78e0d19
Merge branch 'master' into feat_wandb_resume
Borda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have a better way to handle only once displayed Warning. Could be WarningCache. Need to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we reimplement this one?
https://github.com/PyTorchLightning/pytorch-lightning-bolts/blob/13863ccf1f96cb912406c029c50f4253f4599aee/pl_bolts/utils/warnings.py#L7