-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LSF support #5102
Add LSF support #5102
Conversation
We need to do this so we don't send the model to the same device from multiple ranks
Hello @ajtritt! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-09 11:43:15 UTC |
This PR probably requires some changes/additions to the docs. If everyone is okay with these changes I will update the documentation. |
Let's add the LSF environment class here, I'm going to add tests too. |
Codecov Report
@@ Coverage Diff @@
## master #5102 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 214 215 +1
Lines 13900 13988 +88
=======================================
- Hits 12814 12309 -505
- Misses 1086 1679 +593 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@ajtritt I implemented the tests. Could you check my edits and my previous comment? Would be great to have this in 1.4. I will request review from others. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
What does this PR do?
Replaces #4966
Add support for running PyTorch Lightning on systems managed by LSF.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Always.