Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LSF support #5102

Merged
merged 41 commits into from
Jul 9, 2021
Merged

Add LSF support #5102

merged 41 commits into from
Jul 9, 2021

Conversation

ajtritt
Copy link
Contributor

@ajtritt ajtritt commented Dec 12, 2020

What does this PR do?

Replaces #4966

Add support for running PyTorch Lightning on systems managed by LSF.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Always.

@pep8speaks
Copy link

pep8speaks commented Dec 12, 2020

Hello @ajtritt! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-09 11:43:15 UTC

@ajtritt
Copy link
Contributor Author

ajtritt commented Dec 12, 2020

This PR probably requires some changes/additions to the docs. If everyone is okay with these changes I will update the documentation.

@mergify mergify bot requested a review from a team December 12, 2020 14:55
@tchaton tchaton added this to the 1.2 milestone Dec 14, 2020
@Borda Borda modified the milestones: v1.3, v1.4 Apr 27, 2021
@awaelchli awaelchli self-assigned this Jul 9, 2021
@ajtritt ajtritt requested a review from kaushikb11 as a code owner July 9, 2021 09:10
@mergify mergify bot removed the has conflicts label Jul 9, 2021
@awaelchli
Copy link
Contributor

Let's add the LSF environment class here, I'm going to add tests too.
@ajtritt also added docs improvements to the other plugins, but I removed them from this PR.
We can pick them up again from before my commit
d17281c and add them in a separate PR.

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #5102 (7f127c8) into master (1c825a2) will decrease coverage by 4%.
The diff coverage is 92%.

@@           Coverage Diff           @@
##           master   #5102    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         214     215     +1     
  Lines       13900   13988    +88     
=======================================
- Hits        12814   12309   -505     
- Misses       1086    1679   +593     

@awaelchli
Copy link
Contributor

@ajtritt I implemented the tests. Could you check my edits and my previous comment? Would be great to have this in 1.4. I will request review from others.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@tchaton tchaton merged commit 3102922 into Lightning-AI:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants