Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug-fix] Metric reduction with Logging #5150

Merged
merged 8 commits into from
Dec 16, 2020
Merged

[bug-fix] Metric reduction with Logging #5150

merged 8 commits into from
Dec 16, 2020

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Dec 15, 2020 •
edited
Loading

What does this PR do?

Fixes #5146

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Dec 15, 2020
@tchaton tchaton added this to the 1.1.x milestone Dec 15, 2020
@tchaton tchaton added the priority: 0 High priority task label Dec 15, 2020
@codecov
Copy link

codecov bot commented Dec 15, 2020 •
edited
Loading

Codecov Report

Merging #5150 (ba23d77) into master (b4d926b) will increase coverage by 0%.
The diff coverage is 88%.

@@          Coverage Diff           @@
##           master   #5150   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9905    9917   +12     
======================================
+ Hits         9204    9231   +27     
+ Misses        701     686   -15

@tchaton tchaton changed the title [bub-fix] Metric reduction with Logging [bug-fix] Metric reduction with Logging Dec 16, 2020
@tchaton tchaton marked this pull request as ready for review December 16, 2020 09:42
SkafteNicki
SkafteNicki approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tchaton
Copy link
Contributor Author

tchaton commented Dec 16, 2020

@teddykoker @ananyahjha93 Mind a review ?

@williamFalcon williamFalcon merged commit 81fd33b into master Dec 16, 2020
@Borda Borda deleted the bugfix/5146_metrics_reduction_logging branch December 16, 2020 21:21
@awaelchli
Copy link
Contributor

Why did you add the code to the callbacks and not where logging happens? Shouldn't the callback metrics contain the already computed/detached values? Now we have duplicated code, and each callback has to handle the Metric with this special condition? This does not look right.

awaelchli pushed a commit that referenced this pull request Dec 18, 2020
@tchaton @awaelchli
[bug-fix] Metric reduction with Logging (#5150)
6bade18 
* add test

* resolve bug

* udpate test

* wrongly copy / paste

* update test

* resolve a second bug

Co-authored-by: Ubuntu <ubuntu@ip-172-31-62-109.ec2.internal>
tchaton added a commit that referenced this pull request Dec 21, 2020
@tchaton
[bug-fix] Metric reduction with Logging (#5150)
a48ca18 
* add test

* resolve bug

* udpate test

* wrongly copy / paste

* update test

* resolve a second bug

Co-authored-by: Ubuntu <ubuntu@ip-172-31-62-109.ec2.internal>
Borda pushed a commit that referenced this pull request Dec 23, 2020
@tchaton @Borda
[bug-fix] Metric reduction with Logging (#5150)
7605c6f 
* add test

* resolve bug

* udpate test

* wrongly copy / paste

* update test

* resolve a second bug

Co-authored-by: Ubuntu <ubuntu@ip-172-31-62-109.ec2.internal>
Borda pushed a commit that referenced this pull request Dec 29, 2020
@tchaton @Borda
[bug-fix] Metric reduction with Logging (#5150)
1a4ad0f 
* add test

* resolve bug

* udpate test

* wrongly copy / paste

* update test

* resolve a second bug

Co-authored-by: Ubuntu <ubuntu@ip-172-31-62-109.ec2.internal>
Borda pushed a commit that referenced this pull request Jan 4, 2021
@tchaton @Borda
[bug-fix] Metric reduction with Logging (#5150)
323b482 
* add test

* resolve bug

* udpate test

* wrongly copy / paste

* update test

* resolve a second bug

Co-authored-by: Ubuntu <ubuntu@ip-172-31-62-109.ec2.internal>
Borda pushed a commit that referenced this pull request Jan 4, 2021
@tchaton @Borda
[bug-fix] Metric reduction with Logging (#5150)
d757f8b 
* add test

* resolve bug

* udpate test

* wrongly copy / paste

* update test

* resolve a second bug

Co-authored-by: Ubuntu <ubuntu@ip-172-31-62-109.ec2.internal>
Borda pushed a commit that referenced this pull request Jan 5, 2021
@tchaton @Borda
[bug-fix] Metric reduction with Logging (#5150)
6b19198 
* add test

* resolve bug

* udpate test

* wrongly copy / paste

* update test

* resolve a second bug

Co-authored-by: Ubuntu <ubuntu@ip-172-31-62-109.ec2.internal>
tchaton added a commit that referenced this pull request Jan 7, 2021
@tchaton
[Feat] Cleanup ModelCheckpoint / EarlyStopping by moving logic to Log…
5f94900 
…gerConnector (#5218)

* [bug-fix] Metric reduction with Logging (#5150)

* add test

* resolve bug

* udpate test

* wrongly copy / paste

* update test

* resolve a second bug

Co-authored-by: Ubuntu <ubuntu@ip-172-31-62-109.ec2.internal>

* iupdate

* resolve bugs

* add test back

* correct flake8

* resolve flake8

* update on comments

* update tests

* add a test

* add test

* update to Callable

Co-authored-by: Ubuntu <ubuntu@ip-172-31-62-109.ec2.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
priority: 0 High priority task
Projects
None yet
Milestone
pl:1.1.x
Development

Successfully merging this pull request may close these issues.

Metrics reduction during logging/checkpointing
5 participants
@tchaton @awaelchli @SeanNaren @SkafteNicki @williamFalcon