Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prelease 1.1.2rc #5171

Merged
merged 9 commits into from
Dec 17, 2020
Merged

Prelease 1.1.2rc #5171

merged 9 commits into from
Dec 17, 2020

Conversation

SeanNaren
Copy link
Contributor

What does this PR do?

Creates pre-release for 1.1.2rc after a few crucial bug fixes.

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the priority: 1 Medium priority task label Dec 17, 2020
Borda
Borda reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add date and version in chlog

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/__init__.py Outdated Show resolved Hide resolved
Borda
Borda reviewed Dec 17, 2020
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
rohitgr7
rohitgr7 approved these changes Dec 17, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #5171 (d28f843) into master (b16441f) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5171   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9928    9928           
======================================
  Hits         9242    9242           
  Misses        686     686

@SeanNaren SeanNaren merged commit e721b1f into master Dec 17, 2020
@rohitgr7 rohitgr7 deleted the feat/prerelease_1.1.2rc branch December 17, 2020 13:50
awaelchli pushed a commit that referenced this pull request Dec 18, 2020
@SeanNaren @rohitgr7 @awaelchli
Prelease 1.1.2rc (#5171)
105e588 
* update CHANGELOG.md, increment for RC

* Add missing changelog update

* Added a few more

* Move to added

* Address code review

* Missing space

* Remove unreleased

* Remove lines

* Update CHANGELOG.md

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda pushed a commit that referenced this pull request Dec 23, 2020
@SeanNaren @rohitgr7 @Borda
Prelease 1.1.2rc (#5171)
68fe669 
* update CHANGELOG.md, increment for RC

* Add missing changelog update

* Added a few more

* Move to added

* Address code review

* Missing space

* Remove unreleased

* Remove lines

* Update CHANGELOG.md

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda pushed a commit that referenced this pull request Dec 29, 2020
@SeanNaren @rohitgr7 @Borda
Prelease 1.1.2rc (#5171)
067d6c8 
* update CHANGELOG.md, increment for RC

* Add missing changelog update

* Added a few more

* Move to added

* Address code review

* Missing space

* Remove unreleased

* Remove lines

* Update CHANGELOG.md

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda pushed a commit that referenced this pull request Jan 4, 2021
@SeanNaren @rohitgr7 @Borda
Prelease 1.1.2rc (#5171)
ebe79eb 
* update CHANGELOG.md, increment for RC

* Add missing changelog update

* Added a few more

* Move to added

* Address code review

* Missing space

* Remove unreleased

* Remove lines

* Update CHANGELOG.md

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda pushed a commit that referenced this pull request Jan 4, 2021
@SeanNaren @rohitgr7 @Borda
Prelease 1.1.2rc (#5171)
2bb4523 
* update CHANGELOG.md, increment for RC

* Add missing changelog update

* Added a few more

* Move to added

* Address code review

* Missing space

* Remove unreleased

* Remove lines

* Update CHANGELOG.md

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda pushed a commit that referenced this pull request Jan 5, 2021
@SeanNaren @rohitgr7 @Borda
Prelease 1.1.2rc (#5171)
cb45ab0 
* update CHANGELOG.md, increment for RC

* Add missing changelog update

* Added a few more

* Move to added

* Address code review

* Missing space

* Remove unreleased

* Remove lines

* Update CHANGELOG.md

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@teddykoker teddykoker Awaiting requested review from teddykoker

Assignees
No one assigned
Labels
priority: 1 Medium priority task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SeanNaren @Borda @tchaton @rohitgr7