Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip multi-gpu test when running on single-gpu machine #5186

Merged
merged 3 commits into from
Dec 20, 2020

Conversation

awaelchli
Copy link
Contributor

a test that requires 2 gpus should be skipped when running on single-gpu system.

@awaelchli awaelchli added feature Is an improvement or enhancement ci Continuous Integration priority: 2 Low priority task labels Dec 18, 2020
@awaelchli awaelchli added this to the 1.1.x milestone Dec 18, 2020
@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #5186 (351dc6b) into master (618580b) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5186   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9933    9933           
======================================
  Hits         9247    9247           
  Misses        686     686           

tests/models/test_gpu.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added the ready PRs ready to be merged label Dec 19, 2020
@SkafteNicki SkafteNicki merged commit be3e870 into master Dec 20, 2020
@rohitgr7 rohitgr7 deleted the ci/skip-multigpu-test branch December 20, 2020 16:15
Borda pushed a commit that referenced this pull request Dec 23, 2020
* skip test

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Borda pushed a commit that referenced this pull request Dec 29, 2020
* skip test

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Borda pushed a commit that referenced this pull request Jan 4, 2021
* skip test

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Borda pushed a commit that referenced this pull request Jan 4, 2021
* skip test

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Borda pushed a commit that referenced this pull request Jan 5, 2021
* skip test

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration feature Is an improvement or enhancement priority: 2 Low priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants