Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for v1.1.2 #5240

Merged
merged 1 commit into from
Dec 23, 2020
Merged

update for v1.1.2 #5240

merged 1 commit into from
Dec 23, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 23, 2020

What does this PR do?

update chlog and version for release

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the docs Documentation related label Dec 23, 2020
@Borda Borda added this to the 1.1.x milestone Dec 23, 2020
@Borda Borda marked this pull request as ready for review December 23, 2020 07:51
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

@Borda Borda added the ready PRs ready to be merged label Dec 23, 2020
@Borda Borda enabled auto-merge (squash) December 23, 2020 07:57
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #5240 (ab77a73) into master (9a3c035) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5240   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9932    9932           
======================================
+ Hits         9239    9246    +7     
+ Misses        693     686    -7     

@Borda Borda merged commit 5820887 into master Dec 23, 2020
@rohitgr7 rohitgr7 deleted the v1.1.2 branch December 23, 2020 09:22
Borda added a commit that referenced this pull request Dec 23, 2020
Borda added a commit that referenced this pull request Dec 29, 2020
Borda added a commit that referenced this pull request Jan 4, 2021
Borda added a commit that referenced this pull request Jan 4, 2021
Borda added a commit that referenced this pull request Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants