Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isort failures in metrics #5528

Merged

Conversation

arnaudgelas
Copy link
Contributor

@arnaudgelas arnaudgelas commented Jan 15, 2021

Remove from skipped module in pyproject.toml and fix failures on:

  • pytorch_lightning/metrics/*.py

What does this PR do?

Relates to #4805

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda enabled auto-merge (squash) January 15, 2021 15:43
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems you fix introduced some cyclic import, mind check...

pytorch_lightning/metrics/classification/average_precision.py:18: in <module>
    from pytorch_lightning.metrics import Metric
E   ImportError: cannot import name 'Metric'

@Borda Borda added the ready PRs ready to be merged label Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #5528 (73cbbc3) into release/1.2-dev (c8f605e) will increase coverage by 0%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release/1.2-dev   #5528   +/-   ##
===============================================
  Coverage               93%     93%           
===============================================
  Files                  153     152    -1     
  Lines                10803   10741   -62     
===============================================
- Hits                  9999    9953   -46     
+ Misses                 804     788   -16     

@arnaudgelas arnaudgelas force-pushed the fix/isort-pl.metrics branch 2 times, most recently from 387ebd4 to 73cbbc3 Compare January 16, 2021 19:24
@arnaudgelas arnaudgelas force-pushed the fix/isort-pl.metrics branch 2 times, most recently from 266c0ed to 141c4d0 Compare January 18, 2021 09:22
Remove from skipped module in pyproject.toml and fix failures on:
- pytorch_lightning/metrics/*.py
@Borda Borda merged commit 61e1d87 into Lightning-AI:release/1.2-dev Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants