-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix isort failures in metrics #5528
Merged
Borda
merged 1 commit into
Lightning-AI:release/1.2-dev
from
arnaudgelas:fix/isort-pl.metrics
Jan 18, 2021
Merged
Fix isort failures in metrics #5528
Borda
merged 1 commit into
Lightning-AI:release/1.2-dev
from
arnaudgelas:fix/isort-pl.metrics
Jan 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudgelas
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
January 15, 2021 14:35
awaelchli
approved these changes
Jan 15, 2021
Borda
requested changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems you fix introduced some cyclic import, mind check...
pytorch_lightning/metrics/classification/average_precision.py:18: in <module>
from pytorch_lightning.metrics import Metric
E ImportError: cannot import name 'Metric'
arnaudgelas
force-pushed
the
fix/isort-pl.metrics
branch
from
January 15, 2021 16:01
ecd4dff
to
d9f632d
Compare
Borda
approved these changes
Jan 15, 2021
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5528 +/- ##
===============================================
Coverage 93% 93%
===============================================
Files 153 152 -1
Lines 10803 10741 -62
===============================================
- Hits 9999 9953 -46
+ Misses 804 788 -16 |
arnaudgelas
force-pushed
the
fix/isort-pl.metrics
branch
2 times, most recently
from
January 16, 2021 19:24
387ebd4
to
73cbbc3
Compare
s-rog
approved these changes
Jan 18, 2021
justusschock
approved these changes
Jan 18, 2021
arnaudgelas
force-pushed
the
fix/isort-pl.metrics
branch
2 times, most recently
from
January 18, 2021 09:22
266c0ed
to
141c4d0
Compare
Remove from skipped module in pyproject.toml and fix failures on: - pytorch_lightning/metrics/*.py
arnaudgelas
force-pushed
the
fix/isort-pl.metrics
branch
from
January 18, 2021 09:34
141c4d0
to
607a93f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove from skipped module in pyproject.toml and fix failures on:
What does this PR do?
Relates to #4805
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃