-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document exceptions in callbacks #5541
Document exceptions in callbacks #5541
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5541 +/- ##
=======================================
- Coverage 90% 88% -3%
=======================================
Files 170 170
Lines 11807 11650 -157
=======================================
- Hits 10676 10215 -461
- Misses 1131 1435 +304 |
You may want to use the issue as a tracker of all the lines and do it on separate PRs. This also allows external contributors |
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Hello @akihironitta! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-02-15 00:02:26 UTC |
Would you mind reviewing this PR again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition !
What does this PR do?
Part of #5434.
TODO
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃