-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat-BugFix] Resolve custom DataLoader #5745
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
awaelchli,
Borda,
justusschock,
SeanNaren and
williamFalcon
as code owners
February 2, 2021 10:59
Hello @tchaton! Thanks for updating this PR.
Comment last updated at 2021-02-04 20:52:40 UTC |
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5745 +/- ##
================================================
- Coverage 88% 88% -0%
================================================
Files 181 181
Lines 12912 12775 -137
================================================
- Hits 11397 11248 -149
- Misses 1515 1527 +12 |
justusschock
reviewed
Feb 2, 2021
carmocca
reviewed
Feb 2, 2021
carmocca
reviewed
Feb 2, 2021
carmocca
reviewed
Feb 2, 2021
carmocca
reviewed
Feb 2, 2021
carmocca
reviewed
Feb 2, 2021
carmocca
reviewed
Feb 2, 2021
carmocca
reviewed
Feb 3, 2021
carmocca
approved these changes
Feb 3, 2021
SkafteNicki
approved these changes
Feb 3, 2021
…TorchLightning/pytorch-lightning into resolve_custom_dataloader_bug
SeanNaren
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the re-instantiation of custom DataLoader and provides a better error message
Fixes # (issue) <- this links related issue to this PR
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃