Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve manual optimization API #5771

Merged
merged 355 commits into from
Feb 16, 2021
Merged

Improve manual optimization API #5771

merged 355 commits into from
Feb 16, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Feb 3, 2021

What does this PR do?

This PR implements the proposal from #5769.

This PR removes all helpers from LightningOptimizer and leave total control on optimization procedure in manual_optimization mode.
Lightning will only take care of accelerators and precision.

Fixes #5769

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

docs/source/common/optimizers.rst Outdated Show resolved Hide resolved
docs/source/common/optimizers.rst Outdated Show resolved Hide resolved
docs/source/common/optimizers.rst Outdated Show resolved Hide resolved
docs/source/common/optimizers.rst Outdated Show resolved Hide resolved
tests/callbacks/test_finetuning_callback.py Outdated Show resolved Hide resolved
@carmocca carmocca added _Will design Includes a design discussion docs Documentation related feature Is an improvement or enhancement labels Feb 14, 2021
@tchaton tchaton removed the _Will label Feb 16, 2021
@tchaton tchaton merged commit 6e79bef into master Feb 16, 2021
@tchaton tchaton deleted the feat/5769_manual_optimization branch February 16, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion docs Documentation related feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve manual_optimization
9 participants