Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise AttributeError in lightning_getattr and lightning_setattr when attribute not found #6024

Merged
merged 8 commits into from
Feb 18, 2021
Merged

Raise AttributeError in lightning_getattr and lightning_setattr when attribute not found #6024

merged 8 commits into from
Feb 18, 2021

Commits on Feb 18, 2021

  1. Empty commit

    @akihironitta @Borda
    akihironitta authored and Borda committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    f372988 View commit details
    Browse the repository at this point in the history

  2. Raise AttributeError instead of ValueError

    @akihironitta @Borda
    akihironitta authored and Borda committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    d851d36 View commit details
    Browse the repository at this point in the history

  3. Make functions private

    @akihironitta @Borda
    akihironitta authored and Borda committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    3469516 View commit details
    Browse the repository at this point in the history

  4. Update tests

    @akihironitta @Borda
    akihironitta authored and Borda committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    1126e6e View commit details
    Browse the repository at this point in the history

  5. Add match string

    @akihironitta @Borda
    akihironitta authored and Borda committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    87c3670 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
    @akihironitta @awaelchli @Borda
    2 people authored and Borda committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    4338061 View commit details
    Browse the repository at this point in the history

  7. lightning to Lightning

    @akihironitta @Borda
    akihironitta authored and Borda committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    418d934 View commit details
    Browse the repository at this point in the history

  8. Empty commit to trigger CI. Seems stuck

    @carmocca @Borda
    carmocca authored and Borda committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    d7a6f93 View commit details
    Browse the repository at this point in the history