Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HotFix] Resolve TPU Training #6027

Merged
merged 17 commits into from
Feb 17, 2021
Merged

[HotFix] Resolve TPU Training #6027

merged 17 commits into from
Feb 17, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Feb 17, 2021 •
edited by carmocca
Loading

What does this PR do?

Fixes #6004 #5841

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Feb 17, 2021
@tchaton tchaton added this to the 1.2 milestone Feb 17, 2021
@tchaton tchaton added bug Something isn't working feature Is an improvement or enhancement accelerator: tpu Tensor Processing Unit labels Feb 17, 2021
@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #6027 (083beea) into master (6a9cec4) will decrease coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6027    +/-   ##
=======================================
- Coverage      93%     93%    -0%     
=======================================
  Files         160     160            
  Lines       11344   11231   -113     
=======================================
- Hits        10554   10413   -141     
- Misses        790     818    +28

carmocca
carmocca reviewed Feb 17, 2021
View reviewed changes
dockers/tpu-tests/tpu_test_cases.jsonnet Outdated Show resolved Hide resolved
pl_examples/domain_templates/computer_vision_fine_tuning.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/training_type/tpu_spawn.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/tensorboard.py Outdated Show resolved Hide resolved
justusschock
justusschock reviewed Feb 17, 2021
View reviewed changes
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fully agree with @carmocca review + some additional points

pl_examples/domain_templates/computer_vision_fine_tuning.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/tensorboard.py Outdated Show resolved Hide resolved
tests/helpers/utils.py Outdated Show resolved Hide resolved
@carmocca carmocca added priority: 0 High priority task and removed feature Is an improvement or enhancement labels Feb 17, 2021
carmocca
carmocca reviewed Feb 17, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tchaton tchaton enabled auto-merge (squash) February 17, 2021 15:49
tchaton and others added 2 commits February 17, 2021 16:00
@tchaton @Borda
Update pytorch_lightning/plugins/training_type/tpu_spawn.py
1476ef5 
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@tchaton @Borda
Update pytorch_lightning/plugins/training_type/tpu_spawn.py
6deb446 
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@pep8speaks
Copy link

pep8speaks commented Feb 17, 2021 •
edited
Loading

Hello @tchaton! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-17 16:20:07 UTC

@tchaton tchaton added the _Will label Feb 17, 2021
@tchaton tchaton merged commit 6bc4490 into master Feb 17, 2021
@tchaton tchaton deleted the hotfix/tpus branch February 17, 2021 16:40
@zcain117 zcain117 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamFalcon williamFalcon williamFalcon approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees

@tchaton tchaton

Labels
accelerator: tpu Tensor Processing Unit bug Something isn't working priority: 0 High priority task
Projects
None yet
Milestone
pl:1.2
Development

Successfully merging this pull request may close these issues.
8 participants
@tchaton @pep8speaks @williamFalcon @awaelchli @Borda @carmocca @justusschock @kaushikb11