Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase coverage for accelerators [WIP] #6102

Closed
wants to merge 10 commits into from

Conversation

awaelchli
Copy link
Contributor

What does this PR do?

Draft PR, need to deactivate ignore rules first before I can see the uncovered lines.
Will update this PR with new tests for accelerator api.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the ci Continuous Integration label Feb 20, 2021
@awaelchli awaelchli added this to the 1.3 milestone Feb 20, 2021
@awaelchli awaelchli changed the title increase coverage for accelerators increase coverage for accelerators [WIP] Feb 20, 2021
@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #6102 (01f26b4) into master (ae6ce17) will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6102    +/-   ##
=======================================
- Coverage      91%     90%    -1%     
=======================================
  Files         160     161     +1     
  Lines       11405   11442    +37     
=======================================
- Hits        10417   10316   -101     
- Misses        988    1126   +138     

@edenlightning edenlightning removed this from the v1.3 milestone May 4, 2021
@Borda
Copy link
Member

Borda commented May 11, 2021

@awaelchli how is it going here, still WIP or ready to go? 🐰

@awaelchli awaelchli closed this May 18, 2021
@Borda Borda deleted the tests/accelerator-coverage branch June 17, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants