Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable CPU Offload as default for DeepSpeed #6262

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Disable CPU Offload as default for DeepSpeed #6262

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd02f58
Change default for CPU offload to false for best throughput/memory ef…
Mar 1, 2021
9781c2c
Add changelog
Mar 1, 2021
27f86a1
default
Borda Mar 1, 2021
3e931b3
Merge branch 'master' into fix/default_deepspeed
kaushikb11 Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Changed the order of `backward`, `step`, `zero_grad` to `zero_grad`, `backward`, `step` ([#6147](https://github.com/PyTorchLightning/pytorch-lightning/pull/6147))


- Changed default for DeepSpeed CPU Offload to False, due to prohibitively slow speeds at smaller scale ([#6262](https://github.com/PyTorchLightning/pytorch-lightning/pull/6262))


### Deprecated


Expand Down
4 changes: 2 additions & 2 deletions pytorch_lightning/plugins/training_type/deepspeed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def __init__(
self,
zero_optimization: bool = True,
stage: int = 2,
cpu_offload: bool = True,
cpu_offload: bool = False,
contiguous_gradients: bool = True,
overlap_comm: bool = True,
allgather_partitions: bool = True,
Expand Down Expand Up @@ -104,7 +104,7 @@ def __init__(
stage: Different stages of the ZeRO Optimizer. 0 is disabled,
1 is optimizer state partitioning, 2 is optimizer+gradient state partitioning (default: 2)

cpu_offload: Enable offloading optimizer memory and computation to CPU (default: True)
cpu_offload: Enable offloading optimizer memory and computation to CPU (default: False)
Borda marked this conversation as resolved.
Show resolved Hide resolved

contiguous_gradients: Copies gradients to a continuous buffer as they are produced.
Avoids memory fragmentation during backwards. Useful when training large models. (default: True)
Expand Down