Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.2.2 [full merge, no squash] #6304

Merged
merged 11 commits into from
Mar 5, 2021
Merged

Release v1.2.2 [full merge, no squash] #6304

merged 11 commits into from
Mar 5, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Mar 2, 2021 •
edited
Loading

Release v1.2.2 [full merge, no squash]

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki @rohitgr7 @kaushikb11
[Bugfix] Fixed epoch level schedulers not being called when val_check…
0151ab6 
…_interval < 1.0 (Lightning-AI#6075)

* fix bug

* fix tests

* changelog

* fix pep8

* fix tests

* fix and add some tests

* add test for rlop

* chlog

* Update CHANGELOG.md

Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
@codecov
Copy link

codecov bot commented Mar 2, 2021 •
edited
Loading

Codecov Report

Merging #6304 (8c7f562) into release/1.2.x (c219aa4) will decrease coverage by 2%.
The diff coverage is 90%.

@@              Coverage Diff               @@
##           release/1.2.x   #6304    +/-   ##
==============================================
- Coverage             93%     91%    -2%     
==============================================
  Files                160     160            
  Lines              11402   11407     +5     
==============================================
- Hits               10658   10378   -280     
- Misses               744    1029   +285

SeanNaren and others added 4 commits March 2, 2021 21:48
@SeanNaren @Borda @kaushikb11
Fix for multiple callbacks (Lightning-AI#6197)
246c65b 
* Fix for multiple callbacks

* Add CHANGELOG.md

* Remove old params

* Skip tests on windows using ddp

* Change name of the variable to not clash with should stop, which is separate

* Apply suggestions from code review

* Fix params

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@carmocca @kaushikb11
Add checkpoint parameter to on_save_checkpoint (Lightning-AI#6072)
1cebe78 
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
@borisdayma @carmocca
@tchaton @awaelchli @kaushikb11
fix(wandb): prevent WandbLogger from dropping values (Lightning-AI#5931)
3e5584e 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@akihironitta @carmocca @kaushikb11
Call optimizer.zero_grad() before backward inside closure in AutoOpt (
0138f0a 
Lightning-AI#6147)

Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
akihironitta and others added 4 commits March 2, 2021 21:58
@akihironitta @kaushikb11
Remove opt from manual_backward in docs (Lightning-AI#6267)
548241b
@dvolgyes @tchaton
@Borda @kaushikb11
Fix for incorrect usage of detach(), cpu(), to() (Lightning-AI#6216)
7c90913 
* Fix for incorrect detach/cpu calls (Lightning-AI#6214)

* Fix incorrect use of detach(), to(), and cpu(), Lightning-AI#6214

* Fix incorrect use of detach() and cpu(), Lightning-AI#6214

* update pr

* add typing

* chlog

* more...

* revert on module

* update on comments

* revert changes on model

Co-authored-by: tchaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
@SeanNaren @Borda @kaushikb11
Disable CPU Offload as default for DeepSpeed (Lightning-AI#6262)
d47eddd 
* Change default for CPU offload to false for best throughput/memory efficiency

* Add changelog

* default

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@SeanNaren @kaushikb11
[fix] Ensure we check deepspeed/sharded in multinode DDP (Lightning-A…
e9517df 
…I#6297)

* Ensure we check deepspeed/sharded in multinode

* Add CHANGELOG.md

* Add CHANGELOG.md

* Drop mock, use actual multi-gpu node
carmocca
carmocca reviewed Mar 2, 2021
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1b498d1 (#6075)

is missing

CHANGELOG.md Outdated Show resolved Hide resolved
@carmocca carmocca mentioned this pull request Mar 2, 2021
Closed
@kaushikb11
Copy link
Contributor Author

@carmocca #6075 is not missing. Check the first update in Changelog.

@carmocca carmocca added ready PRs ready to be merged Important labels Mar 2, 2021
@carmocca carmocca added this to the 1.2.x milestone Mar 2, 2021
Borda
Borda previously approved these changes Mar 2, 2021
View reviewed changes
@Borda Borda requested review from Borda and carmocca March 2, 2021 19:14
@Borda Borda dismissed their stale review March 2, 2021 19:15

failing tests

@pep8speaks
Copy link

pep8speaks commented Mar 3, 2021 •
edited
Loading

Hello @kaushikb11! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-03 12:33:29 UTC

tchaton
tchaton approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton added the _Will label Mar 3, 2021
Borda
Borda requested changes Mar 3, 2021
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check what is the last commit, seems like merging master...
https://github.com/kaushikb11/pytorch-lightning

@kaushikb11 @Borda
update lightning version to v1.2.2
2a837ac 
remove unneccessary import

Update CHANGELOG

resolve a bug

remove print

resolve bug

fix pep8 issues
Borda
Borda approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, seems fine after clean

@Borda
Copy link
Member

Borda commented Mar 3, 2021

@lexierule mind do merge without squash as we did last time?
in setting allow "rebase merge" - come here, with admin rebase merge - in setting disable "rebase merge"

@Borda
hotfix for PT1.6 and torchtext (Lightning-AI#6323)
430f66f 
* ci: azure reinstall torchtext

* move

* todos

* 0.6.0

* skip examples

* formatter

* skip

* todo

* Apply suggestions from code review

(cherry picked from commit e038e74)
@lexierule lexierule merged commit b3b8f95 into Lightning-AI:release/1.2.x Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton tchaton approved these changes

@Borda Borda Borda approved these changes

@justusschock justusschock Awaiting requested review from justusschock

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

@carmocca carmocca Awaiting requested review from carmocca

Assignees
No one assigned
Labels
ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.2.x
Development

Successfully merging this pull request may close these issues.