Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekly Patch Release v.1.2.3 [full merge, no squash] #6432

Closed
wants to merge 17 commits into from
Closed

Weekly Patch Release v.1.2.3 [full merge, no squash] #6432

wants to merge 17 commits into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 9, 2021

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

awaelchli and others added 17 commits February 24, 2021 10:24
@awaelchli @lexierule
Fix amp autocast (#6080)
7c323ba 
* precision fixes

* add amp test model

* fix test

* revert

* move assert to training step

* fix test

* fix test

* remove unrelated changes

* add changelog

* remove unused import
@SeanNaren @carmocca @lexierule
[Hot Fix] Give priority to plugins to set distributed mode, and then …
0455231 
…accelerator (#6089)

* Give priority to plugins to set distributed mode, and then accelerator

* Add CHANGELOG.md

* Update CHANGELOG.md

* Remove very scary line

* Ensure we set cluster environment after slurm configured if necessary

* Simplify the fix with a reset

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@awaelchli @lexierule
fix amp/apex misconfiguration error for cpu (#6107)
d4dad19 
* fix weird test

* fix apex plugin test

* fix raise

* cpu test

* fix type

* add changelog
@carmocca @lexierule
Update version and remove CHANGELOG whitespace
c219aa4
@SkafteNicki @rohitgr7 @lexierule
[Bugfix] Fixed epoch level schedulers not being called when val_check…
76a6321 
…_interval < 1.0 (#6075)

* fix bug

* fix tests

* changelog

* fix pep8

* fix tests

* fix and add some tests

* add test for rlop

* chlog

* Update CHANGELOG.md

Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
@SeanNaren @Borda @lexierule
Fix for multiple callbacks (#6197)
4b71a83 
* Fix for multiple callbacks

* Add CHANGELOG.md

* Remove old params

* Skip tests on windows using ddp

* Change name of the variable to not clash with should stop, which is separate

* Apply suggestions from code review

* Fix params

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@carmocca @kaushikb11 @lexierule
Add checkpoint parameter to on_save_checkpoint (#6072)
9329f58 
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
@borisdayma @carmocca
@tchaton @awaelchli @lexierule
fix(wandb): prevent WandbLogger from dropping values (#5931)
5abfd2c 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@akihironitta @carmocca @lexierule
Call optimizer.zero_grad() before backward inside closure in AutoOpt (
3c498ce 
#6147)

Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
@akihironitta @lexierule
Remove opt from manual_backward in docs (#6267)
09b287a
@dvolgyes @tchaton
@Borda @lexierule
Fix for incorrect usage of detach(), cpu(), to() (#6216)
ad61624 
* Fix for incorrect detach/cpu calls (#6214)

* Fix incorrect use of detach(), to(), and cpu(), #6214

* Fix incorrect use of detach() and cpu(), #6214

* update pr

* add typing

* chlog

* more...

* revert on module

* update on comments

* revert changes on model

Co-authored-by: tchaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
@SeanNaren @Borda @lexierule
Disable CPU Offload as default for DeepSpeed (#6262)
fc95f00 
* Change default for CPU offload to false for best throughput/memory efficiency

* Add changelog

* default

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@SeanNaren @lexierule
[fix] Ensure we check deepspeed/sharded in multinode DDP (#6297)
c5e9d67 
* Ensure we check deepspeed/sharded in multinode

* Add CHANGELOG.md

* Add CHANGELOG.md

* Drop mock, use actual multi-gpu node
@kaushikb11 @lexierule
update lightning version to v1.2.2
9f3ef1b 
remove unneccessary import

Update CHANGELOG

resolve a bug

remove print

resolve bug

fix pep8 issues
@Borda @lexierule
hotfix for PT1.6 and torchtext (#6323)
b3b8f95 
* ci: azure reinstall torchtext

* move

* todos

* 0.6.0

* skip examples

* formatter

* skip

* todo

* Apply suggestions from code review

(cherry picked from commit e038e74)
@carmocca @tchaton
Fix ModelPruning(make_pruning_permanent=True) buffers getting removed…
cf9e408 
… when saved during training (#6073)

Co-authored-by: chaton <thomas@grid.ai>
@SkafteNicki @Borda
@rohitgr7 @awaelchli @tchaton
Update docs on arg train_dataloader in fit (#6076)
de0efa9 
* add to docs

* update docs

* Apply suggestions from code review

* Update pytorch_lightning/core/hooks.py

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* nested loaders

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* shorten text length

* Update pytorch_lightning/core/hooks.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@Borda
Copy link
Member Author

Borda commented Mar 9, 2021

duplicate to #6431 resolves #6428

@Borda Borda closed this Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga Awaiting requested review from lantiga lantiga will be requested when the pull request is marked ready for review lantiga is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris will be requested when the pull request is marked ready for review ethanwharris is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock will be requested when the pull request is marked ready for review justusschock is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton will be requested when the pull request is marked ready for review tchaton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Borda @awaelchli @SeanNaren @carmocca @SkafteNicki @borisdayma @akihironitta @dvolgyes @kaushikb11