Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Move init dist connection into the setup function #6506

Merged
merged 33 commits into from
Mar 18, 2021
Merged

[Fix] Move init dist connection into the setup function #6506

merged 33 commits into from
Mar 18, 2021

Commits on Mar 13, 2021

  1. Move connection setup into the setup function. Call setup hook after … 

    …we set up the accelerator
    SeanNaren committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    6bf721e View commit details
    Browse the repository at this point in the history

  2. Added CHANGELOG.md

    SeanNaren committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    1576176 View commit details
    Browse the repository at this point in the history

  3. fix setup order in callback test

    @awaelchli
    awaelchli committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    7148ee6 View commit details
    Browse the repository at this point in the history

  4. fix input arguments in test

    @awaelchli
    awaelchli committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    4fd0c02 View commit details
    Browse the repository at this point in the history

  5. Mock distributed function, remove protection to turn into training ty… 

    …pe hook
    SeanNaren committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    cbfa681 View commit details
    Browse the repository at this point in the history

  6. Remove import

    SeanNaren committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    2a1dfbf View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. Add missing mock, ensure custom plugin does not create children process

    SeanNaren committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    e9c3f83 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/setup_ddp_hook

    SeanNaren committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    2141a1f View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Merge branch 'master' into fix/setup_ddp_hook

    @SeanNaren
    SeanNaren committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    96ca54f View commit details
    Browse the repository at this point in the history

  2. Skip test on windows

    SeanNaren committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    ffe1c3f View commit details
    Browse the repository at this point in the history

  3. Update deepspeed to init connection in setup

    SeanNaren committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    1709cdb View commit details
    Browse the repository at this point in the history

  4. Do not initialize distributed module

    SeanNaren committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    708f97f View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Move DeepSpeed tests to special tests since dist communication is bei… 

    …ng set up
    SeanNaren committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    ec33b96 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/setup_ddp_hook

    SeanNaren committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    d782554 View commit details
    Browse the repository at this point in the history

  3. Special the test to see if this fixes CI

    SeanNaren committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    0c03487 View commit details
    Browse the repository at this point in the history

  4. Delete accelerator connector test to see if its causing build to fail

    SeanNaren committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    edde60b View commit details
    Browse the repository at this point in the history

  5. Delete deepspeed test

    SeanNaren committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    9d31742 View commit details
    Browse the repository at this point in the history

  6. Revert "Delete accelerator connector test to see if its causing build… 

    … to fail"

This reverts commit edde60b
    SeanNaren committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    9db893a View commit details
    Browse the repository at this point in the history

  7. Revert "Delete deepspeed test" 

    This reverts commit 9d317429
    SeanNaren committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    56ef252 View commit details
    Browse the repository at this point in the history

  8. Reverse hook

    SeanNaren committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    cad0671 View commit details
    Browse the repository at this point in the history

  9. Reverse setup hooks to debug again

    SeanNaren committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    6b7d835 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Add todo so i know where i left off

    SeanNaren committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    4651e57 View commit details
    Browse the repository at this point in the history

  2. For single device move in pre_dispatch after setup function

    SeanNaren committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    d7ec33e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix/setup_ddp_hook

    SeanNaren committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    72097ba View commit details
    Browse the repository at this point in the history

  4. Add additional model to device hook if any additional parameters have… 

    … been set
    SeanNaren committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    bd2a53a View commit details
    Browse the repository at this point in the history

  5. See if we can enable deepspeed tests

    SeanNaren committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    b5450de View commit details
    Browse the repository at this point in the history

  6. Revert "See if we can enable deepspeed tests" 

    This reverts commit b5450de
    SeanNaren committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    136ddc5 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. See if this hook approach works

    SeanNaren committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    0210f17 View commit details
    Browse the repository at this point in the history

  2. Introduce new granular hooks

    SeanNaren committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    1bae940 View commit details
    Browse the repository at this point in the history

  3. Remove import, fix tpu spawn by moving the function to setup

    SeanNaren committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    69d6c32 View commit details
    Browse the repository at this point in the history

  4. Added missing special test

    SeanNaren committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    91fff3a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into fix/setup_ddp_hook 

    # Conflicts:
#	CHANGELOG.md
    SeanNaren committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    88e2e09 View commit details
    Browse the repository at this point in the history

  6. Clean up the setup comment, since its run on train and test

    SeanNaren committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    3eced98 View commit details
    Browse the repository at this point in the history