Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set sync_batchnorm for training_type_plugin #6536

Merged
merged 17 commits into from
Mar 19, 2021
Merged
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,11 @@ def resolve_training_type_plugin(self, training_type: TrainingTypePlugin) -> Tra
if hasattr(training_type, 'num_nodes') and getattr(training_type, 'num_nodes') is None:
training_type.num_nodes = self.num_nodes

# Automatically set sync_batchnorm.
# Useful for custom plugins.
if hasattr(training_type, 'sync_batchnorm'):
amogkam marked this conversation as resolved.
Show resolved Hide resolved
training_type.sync_batchnorm = self.sync_batchnorm

return training_type

def select_accelerator(self) -> Accelerator:
Expand Down
22 changes: 22 additions & 0 deletions tests/plugins/test_custom_plugin.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
from pytorch_lightning import Trainer
from pytorch_lightning.plugins import DDPPlugin
from tests.helpers import BoringModel


class CustomParallelPlugin(DDPPlugin):
def __init__(self, **kwargs):
super().__init__(**kwargs)
amogkam marked this conversation as resolved.
Show resolved Hide resolved


def test_sync_batchnorm_set(tmpdir):
model = BoringModel()
plugin = CustomParallelPlugin()
assert plugin.sync_batchnorm is False
trainer = Trainer(
max_epochs=1,
plugins=[plugin],
default_root_dir=tmpdir,
sync_batchnorm=True,
)
trainer.fit(model)
assert plugin.sync_batchnorm is True