Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekly Patch Release v.1.2.4 [full merge, no squash] #6545

Merged
merged 19 commits into from
Mar 16, 2021
Merged

Weekly Patch Release v.1.2.4 [full merge, no squash] #6545

merged 19 commits into from
Mar 16, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Mar 16, 2021 •
edited by Borda
Loading

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Palzer and others added 6 commits March 16, 2021 10:07
@Palzer
fixed bug where tuner would not tune lr if also tuning batch_size (#4688
d061cbc 
)

* fixed bug where tuner would not tune lr if also tuning batch_size

* added a '+1' to computing the smoothed loss. This maintains the behavior for the smoothed loss as before the bug fix

* pep8 fix

* add changelog

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
(cherry picked from commit 523c59b)
@awaelchli
fix logger creating directory structure too early in DDP (#6380)
c395040 
* fix

* add simple test

* fix imports

* add changelog

* tighter test with on_fit_start hook closer to the dispatch call

* move class inside test f unction

* add a comment

(cherry picked from commit fc6d402)
@SeanNaren
Set find unused parameters to True by default to fix breaking compati…
745d54d 
…bility (#6438)

* Set find unused parameters to True by default to fix breaking models, add suggestion to re-enable

* Add changelog

(cherry picked from commit c81b2a8)
@SeanNaren
[Fix] Ensure we set the default device before initializing deepspeed (#…
6ee1627 
…6460)

* Ensure we set the default device before initializing deepspeed

* Add CHANGELOG.md

* Update pytorch_lightning/plugins/training_type/deepspeed.py

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>

(cherry picked from commit 1c013b4)
@kaushikb11
Hotfix for torchvision (#6476)
344b455 
(cherry picked from commit 079fe9b)
@rohitgr7
Disable batch transfer in DP mode (#6098)
dfba137 
* add exceptions and test

* hook

* fix

* clean up

* clean up

* regex

* regex

* docs

* rev

* comment and docs

* chlog

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Apply suggestions from code review

Co-authored-by: chaton <thomas@grid.ai>

* Monkey-patch device count

* docs

* pep

* api_change

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: chaton <thomas@grid.ai>

(cherry picked from commit c53edce)
tchaton
tchaton approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@SeanNaren SeanNaren marked this pull request as ready for review March 16, 2021 16:16
SeanNaren and others added 12 commits March 16, 2021 18:58
@Borda
Add missing imports & stage
b169fb5 
Add missing stage
@tchaton @Borda
[bugfix] Perform reduction for dict in training_step and DP (#6324)
0560c97 
* fix

* update

* update

* add changelog

* Update CHANGELOG.md

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update tests/accelerators/test_dp.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* update changelog

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

(cherry picked from commit 248a8e8)
@awaelchli @Borda
Fix tuner.scale_batch_size not finding batch size attribute when usin…
fc3503b 
…g datamodule (#5968)

(cherry picked from commit b2bcad1)
@awaelchli @Borda
Handle torch.jit scripted modules in layer summary (#6511)
50c15dc 
(cherry picked from commit 02fa32b)
@Borda
CI: resume testing with py3.8 (#6516)
2178b53 
* testing on python 3.8

* req

(cherry picked from commit 156847b)
@awaelchli @Borda
fix attribute access in LightningModule.toggle_optimizer (#6513)
133fd82 
(cherry picked from commit ea36ee3)
@amogkam @Borda
Custom Plugin is_distributed (#6537)
4e37c57 
* return from plugin

* dont return for tpu

(cherry picked from commit 6a14146)
@Borda
refactor reading env defaults (#6510)
fed7949 
* change tests

* fix

* test

* _defaults_from_env_vars

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
(cherry picked from commit 0f07eaf)
@tchaton @Borda
[bug] Update broadcast + reduce decision ModelCheckpoint] (#6410)
293ff2a 
* resolve bug

* update

* update changelog

* update PR

* Update pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* add todo

* resolve issues

* resolve flake8

* update

* add coverage for reduce

* wip

* restore back to brodbact

* remove test.py

* resolve flake8

* update

* check world size

* resolve test

* update

* use pytorch version when defined

* update on comments

* update on comments

* flake8

* resolve bugs

* Update CHANGELOG.md

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* update

* update

* update

* update

* remove test

* update

* resolve flake8

* update

* update

* update

* proxy

* update

* update

* resolve typo

* prune

* update parallel

* update

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

(cherry picked from commit 0544efd)
@Borda
v1.2.4 & chnagelog
7d4db76 
Remove import

Fix runif import

Increment version

Update CHANGELOG.md
@kaushikb11 @Borda
Fix: Train loop config validation was run during trainer.predict (#…
f35b9b8 
…6541)
@SeanNaren @Borda
Expose DeepSpeed FP16 parameters due to loss instability (#6115)
c6e1035 
* Expose deepspeed config parameters to init function due to instability in parameters

* See if tests can run on normal CI, without special tests

* Add changelog

* Update pytorch_lightning/plugins/training_type/deepspeed.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

(cherry picked from commit 432e563)

Add missing config
@Borda Borda added the let's do it! approved to implement label Mar 16, 2021
@Borda Borda added this to the 1.2.x milestone Mar 16, 2021
@lexierule lexierule merged commit 7114c2d into release/1.2.x Mar 16, 2021
@lexierule lexierule deleted the v1.2.4 branch March 16, 2021 19:37
@awaelchli awaelchli mentioned this pull request Mar 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca Awaiting requested review from carmocca

@edenlightning edenlightning Awaiting requested review from edenlightning

@justusschock justusschock Awaiting requested review from justusschock

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
let's do it! approved to implement
Projects
None yet
Milestone
pl:1.2.x
Development

Successfully merging this pull request may close these issues.
9 participants
@SeanNaren @awaelchli @Borda @tchaton @lexierule @Palzer @kaushikb11 @rohitgr7 @amogkam