Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match the number of outputs of backward with forward for AllGatherGrad #6625

Merged
merged 4 commits into from
Mar 25, 2021
Merged

Match the number of outputs of backward with forward for AllGatherGrad #6625

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ce85d2
match the number of outputs of backward with that of inputs of forwar…
Mar 22, 2021
95f5b48
add test_all_gather_sync_grads
ArvinZhuang Mar 24, 2021
e3c4c13
Update tests/utilities/test_all_gather_grad.py
carmocca Mar 24, 2021
bd0e226
Update tests/utilities/test_all_gather_grad.py
carmocca Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytorch_lightning/utilities/distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def backward(ctx, *grad_output):

torch.distributed.all_reduce(grad_output, op=torch.distributed.ReduceOp.SUM, async_op=False, group=ctx.group)

return grad_output[torch.distributed.get_rank()]
return grad_output[torch.distributed.get_rank()], None


def all_gather_ddp_if_available(
Expand Down