Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remake nvidia docker #6686

Merged
merged 10 commits into from
Mar 29, 2021
Merged

remake nvidia docker #6686

merged 10 commits into from
Mar 29, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 26, 2021

What does this PR do?

make the Nvidia image lighter

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the feature Is an improvement or enhancement label Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #6686 (f55b4dd) into master (6b990f3) will decrease coverage by 7%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6686    +/-   ##
=======================================
- Coverage      91%     84%    -7%     
=======================================
  Files         192     192            
  Lines       12267   12703   +436     
=======================================
- Hits        11180   10696   -484     
- Misses       1087    2007   +920     

@Borda Borda requested a review from carmocca March 26, 2021 13:42
@Borda Borda marked this pull request as ready for review March 26, 2021 13:42
@Borda Borda enabled auto-merge (squash) March 26, 2021 13:43
dockers/nvidia/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@Borda Borda added the ready PRs ready to be merged label Mar 26, 2021
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

dockers/nvidia/Dockerfile Show resolved Hide resolved
@Borda Borda merged commit dcf6e4e into master Mar 29, 2021
@Borda Borda deleted the ci/nvidia branch March 29, 2021 08:39
@carmocca carmocca modified the milestones: 1.3, 1.2.x Mar 29, 2021
carmocca pushed a commit that referenced this pull request Mar 30, 2021
* use latest

* remake

* examples
@carmocca carmocca mentioned this pull request Mar 30, 2021
Borda added a commit that referenced this pull request Mar 30, 2021
* use latest

* remake

* examples
lexierule pushed a commit that referenced this pull request Mar 30, 2021
* use latest

* remake

* examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants