Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fixture for global rank variable reset #6839

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 5, 2021

What does this PR do?

For #6802

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the ci Continuous Integration label Apr 5, 2021
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #6839 (62912af) into master (22a266d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6839   +/-   ##
======================================
  Coverage      91%     91%           
======================================
  Files         192     192           
  Lines       12191   12191           
======================================
  Hits        11145   11145           
  Misses       1046    1046           

@awaelchli awaelchli changed the title [WIP] CI: fixture for global rank variable reset CI: fixture for global rank variable reset Apr 5, 2021
@carmocca
Copy link
Contributor

carmocca commented Apr 6, 2021

Still WIP? Looks good to me

@awaelchli awaelchli marked this pull request as ready for review April 6, 2021 07:38
@awaelchli
Copy link
Contributor Author

can be included as standalone PR or be merged into #6802, what you prefer.

@carmocca carmocca added the ready PRs ready to be merged label Apr 6, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standalone is okay

@carmocca carmocca enabled auto-merge (squash) April 6, 2021 14:22
@carmocca carmocca added this to the 1.2.x milestone Apr 6, 2021
@carmocca carmocca merged commit b7a22ba into master Apr 6, 2021
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @awaelchli !

@carmocca carmocca deleted the ci/rank-reset branch April 6, 2021 16:37
@SeanNaren SeanNaren mentioned this pull request Apr 12, 2021
SeanNaren pushed a commit that referenced this pull request Apr 13, 2021
lexierule pushed a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants