-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: fixture for global rank variable reset #6839
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6839 +/- ##
======================================
Coverage 91% 91%
======================================
Files 192 192
Lines 12191 12191
======================================
Hits 11145 11145
Misses 1046 1046 |
Still WIP? Looks good to me |
can be included as standalone PR or be merged into #6802, what you prefer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standalone is okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @awaelchli !
(cherry picked from commit b7a22ba)
(cherry picked from commit b7a22ba)
What does this PR do?
For #6802
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃