Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finetuning complex models correctly unfreezes. #6880

Merged
merged 5 commits into from
Apr 8, 2021
Merged

Fix finetuning complex models correctly unfreezes. #6880

merged 5 commits into from
Apr 8, 2021

Conversation

scart97
Copy link
Contributor

@scart97 scart97 commented Apr 7, 2021

What does this PR do?

This changes the way the nodes are filtered in the FinetuningCallback to avoid the problem with complex models described in the issue.

Fixes #6879

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #6880 (39efb11) into master (9fbe724) will decrease coverage by 4%.
The diff coverage is 100%.

❗ Current head 39efb11 differs from pull request most recent head f78fa8d. Consider uploading reports for the commit f78fa8d to get more accurate results

@@           Coverage Diff           @@
##           master   #6880    +/-   ##
=======================================
- Coverage      91%     87%    -4%     
=======================================
  Files         193     193            
  Lines       12299   12298     -1     
=======================================
- Hits        11252   10707   -545     
- Misses       1047    1591   +544     

@carmocca carmocca added this to the 1.2.x milestone Apr 8, 2021
@carmocca carmocca added the bug Something isn't working label Apr 8, 2021
@mergify mergify bot added the has conflicts label Apr 8, 2021
@mergify mergify bot removed the has conflicts label Apr 8, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for this contribution !

@kaushikb11 kaushikb11 merged commit eb15abc into Lightning-AI:master Apr 8, 2021
@SeanNaren SeanNaren mentioned this pull request Apr 12, 2021
SeanNaren pushed a commit that referenced this pull request Apr 13, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>

(cherry picked from commit eb15abc)
lexierule pushed a commit that referenced this pull request Apr 14, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>

(cherry picked from commit eb15abc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseFinetuning callback can add the same parameter multiple times to the optimizer
4 participants