-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix finetuning complex models correctly unfreezes. #6880
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6880 +/- ##
=======================================
- Coverage 91% 87% -4%
=======================================
Files 193 193
Lines 12299 12298 -1
=======================================
- Hits 11252 10707 -545
- Misses 1047 1591 +544 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks for this contribution !
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com> (cherry picked from commit eb15abc)
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com> (cherry picked from commit eb15abc)
What does this PR do?
This changes the way the nodes are filtered in the FinetuningCallback to avoid the problem with complex models described in the issue.
Fixes #6879
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃