Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exception raising #6901

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Conversation

kandluis
Copy link
Contributor

@kandluis kandluis commented Apr 8, 2021

What does this PR do?

Attach additional information and re-raise exception appropriately.

Using type(e)(<new message>) doesn't work for exceptions that have different number of parameters in the __init__. The existing code hides the original stack-trace which complicates debugging.
This change uses Python's built-in exception mechanism. See https://docs.python.org/3/library/exceptions.html#built-in-exceptions.

One possible drawback is that a new ValueError exception is raised (rather than the original).

Note:
We should probably try to discourage try/catch blocks that catch all exceptions (like this one) especially in library code.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kandluis kandluis marked this pull request as ready for review April 8, 2021 18:09
@Borda Borda added the bug Something isn't working label Apr 8, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@awaelchli awaelchli merged commit 90e37ba into Lightning-AI:master Apr 8, 2021
@kandluis kandluis deleted the bugfix/exception branch April 9, 2021 00:36
@SeanNaren SeanNaren mentioned this pull request Apr 12, 2021
SeanNaren pushed a commit that referenced this pull request Apr 13, 2021
(cherry picked from commit 90e37ba)
SeanNaren pushed a commit that referenced this pull request Apr 13, 2021
(cherry picked from commit 90e37ba)
lexierule pushed a commit that referenced this pull request Apr 14, 2021
(cherry picked from commit 90e37ba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants