-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Checkpoint issue when using Horovod distributed backend (PyTorchLightning#6947) #6958
Merged
SeanNaren
merged 2 commits into
Lightning-AI:master
from
liob:bugfix-#6947-Checkpoint-issue-when-using-Horovod-distributed-backend
Apr 13, 2021
Merged
Fix Checkpoint issue when using Horovod distributed backend (PyTorchLightning#6947) #6958
SeanNaren
merged 2 commits into
Lightning-AI:master
from
liob:bugfix-#6947-Checkpoint-issue-when-using-Horovod-distributed-backend
Apr 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ightning#6947) Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6958 +/- ##
========================================
+ Coverage 43% 87% +44%
========================================
Files 194 194
Lines 12365 12346 -19
========================================
+ Hits 5330 10781 +5451
+ Misses 7035 1565 -5470 |
awaelchli
added
checkpointing
Related to checkpointing
distributed
Generic distributed-related topic
bug
Something isn't working
labels
Apr 11, 2021
awaelchli
approved these changes
Apr 11, 2021
ananthsub
approved these changes
Apr 12, 2021
SeanNaren
approved these changes
Apr 12, 2021
…when-using-Horovod-distributed-backend
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
checkpointing
Related to checkpointing
distributed
Generic distributed-related topic
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6947: ModelCheckpoint failed when using the save_top_k feature because the ReduceOp was not considered when evaluating reduce_sum.
cc @awaelchli
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list: