Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove evaluation loop legacy dict returns for *_epoch_end hooks #6973

Merged

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Apr 12, 2021

What does this PR do?

Split out from #6969

This seems like it's been deprecated since v0.9.1 and doesn't change the behavior.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #6973 (f7a0679) into master (80c5293) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6973    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         194     194            
  Lines       12366   12326    -40     
=======================================
- Hits        11350   10669   -681     
- Misses       1016    1657   +641     

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we had a test checking this warning message

pytorch_lightning/trainer/evaluation_loop.py Outdated Show resolved Hide resolved
@carmocca carmocca changed the title Remove deprecation warning from evaluation loop Remove evaluation loop legacy dict returns for *_epoch_end hooks Apr 13, 2021
@carmocca carmocca added this to the 1.3 milestone Apr 13, 2021
@carmocca carmocca added the ready PRs ready to be merged label Apr 13, 2021
Copy link
Contributor Author

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the additional cleanup @carmocca !

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@awaelchli awaelchli enabled auto-merge (squash) April 13, 2021 08:43
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks.

@awaelchli awaelchli merged commit e891ceb into Lightning-AI:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants