-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove evaluation loop legacy dict returns for *_epoch_end
hooks
#6973
Remove evaluation loop legacy dict returns for *_epoch_end
hooks
#6973
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6973 +/- ##
=======================================
- Coverage 92% 87% -5%
=======================================
Files 194 194
Lines 12366 12326 -40
=======================================
- Hits 11350 10669 -681
- Misses 1016 1657 +641 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we had a test checking this warning message
*_epoch_end
hooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the additional cleanup @carmocca !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks.
What does this PR do?
Split out from #6969
This seems like it's been deprecated since v0.9.1 and doesn't change the behavior.
Before submitting
PR review