Fix issue_703: backward compatibility with python3.6 #715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Distributed modes don't work on my machines.
test_amp.py::test_amp_gpu_ddp
freezes.It is not related with pytorch-lightning, and it is not related with this PR (master branch freezed too, in pure pytorch too, other ML too).
So I can't run the tests and I tested them manually (examples without distributed modes)
What does this PR do?
Fixes #703
Backward compatibility with python3.6
Fitting with log_gpu_memory=True in the Trainer fails in python3.6 version.
Reason:
subprocess.run
is used withcapture_output
which is valid only for the python >= 3.7See also workaround to maintain python3.6:
https://stackoverflow.com/questions/53209127/
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
I'll wait.