-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update test for resume_from_checkpoint on missing file #7255
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7255 +/- ##
======================================
Coverage 87% 87%
======================================
Files 200 200
Lines 12895 12895
======================================
Hits 11259 11259
Misses 1636 1636 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@awaelchli GPU failure looks real |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
yeah looks real from master xD |
What does this PR do?
Follow up to #7075
Updates the test docstring
Updates the test to test the file not found error only
Adds missing changelog
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃