Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test for resume_from_checkpoint on missing file #7255

Merged
merged 4 commits into from
May 4, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 28, 2021

What does this PR do?

Follow up to #7075

Updates the test docstring
Updates the test to test the file not found error only
Adds missing changelog

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added ci Continuous Integration priority: 2 Low priority task labels Apr 28, 2021
@awaelchli awaelchli added this to the v1.3 milestone Apr 28, 2021
@awaelchli awaelchli marked this pull request as ready for review April 28, 2021 14:17
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #7255 (a12c1c8) into master (f135deb) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7255   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         200     200           
  Lines       12895   12895           
======================================
  Hits        11259   11259           
  Misses       1636    1636           

@carmocca carmocca added the ready PRs ready to be merged label Apr 28, 2021
@mergify mergify bot removed the has conflicts label May 4, 2021
@awaelchli awaelchli enabled auto-merge (squash) May 4, 2021 00:45
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carmocca
Copy link
Contributor

carmocca commented May 4, 2021

@awaelchli GPU failure looks real

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli
Copy link
Contributor Author

@awaelchli GPU failure looks real

yeah looks real from master xD

@awaelchli awaelchli merged commit b780af5 into master May 4, 2021
@awaelchli awaelchli deleted the tests/update-resume-test branch May 4, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration priority: 2 Low priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants