MLFlow now uses env variable as default tracking uri #7457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify behavior of boolean values on the logger flag for Trainer.
|
Hello @00sapo! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-12 08:56:34 UTC |
tchaton
reviewed
May 10, 2021
Co-authored-by: thomas chaton <thomas@grid.ai>
awaelchli
approved these changes
May 10, 2021
edgarriba
approved these changes
May 10, 2021
Codecov Report
@@ Coverage Diff @@
## master #7457 +/- ##
=======================================
Coverage 87% 88%
=======================================
Files 200 199 -1
Lines 12894 13067 +173
=======================================
+ Hits 11236 11437 +201
+ Misses 1658 1630 -28 |
Borda
approved these changes
May 11, 2021
00sapo
requested review from
carmocca,
justusschock,
kaushikb11,
SeanNaren and
williamFalcon
as code owners
|
added changelog. ready to go <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It changes the initialization of MLFlowLogger so that it uses the environment variable MLFLOW_TRACKING_URI by default
Fixes #6894